Skip to content

Commit 577bfd4

Browse files
committed
EAMxx: pass mach name rather than type in a few places
1 parent c986aa1 commit 577bfd4

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

components/eamxx/scripts/gather_all_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def formulate_command(self, machine):
2626
# gather-all runs on login, not compute nodes, so we cannot rely on
2727
# probed values to be accurate, so we should not set CTEST_PARALLEL_LEVEL
2828
# based on these potentially wrong values.
29-
env_setup = get_mach_env_setup_command(machine, ctest_j=-1)
29+
env_setup = get_mach_env_setup_command(machine.name, ctest_j=-1)
3030

3131
env_setup_str = " && ".join(env_setup)
3232

components/eamxx/scripts/machines_specs.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -397,20 +397,21 @@ def get_mach_env_setup_command(machine, ctest_j=None):
397397
ctest_j=-1 -> Skip CTEST_PARALLEL_LEVEL
398398
"""
399399

400-
mach_custom_env = machine.env_setup
400+
mach = get_machine(machine)
401+
mach_custom_env = mach.env_setup
401402
if ctest_j != -1:
402-
ctest_j = machine.num_run_res if ctest_j is None else ctest_j
403+
ctest_j = mach.num_run_res if ctest_j is None else ctest_j
403404
mach_custom_env.append("export CTEST_PARALLEL_LEVEL={}".format(ctest_j))
404405

405-
if not machine.uses_gpu():
406+
if not mach.uses_gpu():
406407
mach_custom_env.append("export OMP_PROC_BIND=spread")
407408

408409
return mach_custom_env
409410

410411
###############################################################################
411412
def setup_mach_env(machine, ctest_j=None):
412413
###############################################################################
413-
assert_machine_supported(machine.name)
414+
assert_machine_supported(machine)
414415

415416
env_setup = get_mach_env_setup_command(machine, ctest_j=ctest_j)
416417

components/eamxx/scripts/scripts_ctest_driver.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from utils import run_cmd, expect, check_minimum_python_version
2-
from machines_specs import is_machine_supported, setup_mach_env
2+
from machines_specs import is_machine_supported, setup_mach_env, get_machine
33

44
check_minimum_python_version(3, 4)
55

@@ -51,7 +51,7 @@ def __init__(self, submit=False, machine=None, root_dir=None, work_dir=None, dry
5151

5252
# Load env, but do not set CTEST_PARALLEL_JOBS. This code runs on login
5353
# nodes, so resource probing will not always be accurate.
54-
setup_mach_env(self._machine, ctest_j=-1)
54+
setup_mach_env(get_machine(self._machine), ctest_j=-1)
5555

5656
###############################################################################
5757
def generate_ctest_config(self, extra_configs):

components/eamxx/scripts/test_all_scream.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def __init__(self, cxx_compiler=None, f90_compiler=None, c_compiler=None,
173173
# Need to happen before compiler probing
174174
if not self._preserve_env:
175175
# Setup the env on this machine
176-
setup_mach_env(self._machine, ctest_j=ctest_max_jobs)
176+
setup_mach_env(self._machine.name, ctest_j=ctest_max_jobs)
177177

178178
############################################
179179
# Check repo status #

0 commit comments

Comments
 (0)