Skip to content

fix shoc warning of unused vars in rel blds #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fix shoc warning of unused vars in rel blds #2951

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02b3d75
fix shoc warning unused vars
mahf708 Aug 16, 2024
62cfa47
fix typo in assert
mahf708 Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions components/eamxx/src/physics/shoc/eamxx_shoc_process_interface.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,10 @@ class SHOCMacrophysics : public scream::AtmosphereProcess

cldfrac_liq_prev(i,k)=cldfrac_liq(i,k);

const auto range = ekat::range<IntSmallPack>(k*Spack::n);
const Smask in_nlev_range = (range < nlev);

// Inverse of Exner. Assert that exner != 0 when in range before computing.
// Inverse of Exner. In non-rel builds, assert that exner != 0 when in range before computing.
const Spack exner = PF::exner_function(p_mid(i,k));
const Smask nonzero = (exner != 0);
EKAT_KERNEL_ASSERT((nonzero || !in_nlev_range).all());
EKAT_KERNEL_ASSERT((nonzero || !(ekat::range<IntSmallPack>(k*Spack::n) < nlev)).all());
inv_exner(i,k).set(nonzero, 1/exner);

tke(i,k) = ekat::max(mintke, tke(i,k));
Expand Down