Fix hist regex for scream #2957
Conversation
The file names in the output testmods were producing files that were getting skipped by CIME due to not matching the regex in config_archive.xml.
jgfouca
force-pushed
the
jgfouca/fix_hist_regex
branch
from
99d08e7 to
118865f
Compare
|
Note, the only place I found the problematic file extension being used is in the output testmods. When those testmods are not being used, I'm not sure how the file names are getting created. |
| --freq HIST_N \ | ||
| --freq-units HIST_OPTION \ | ||
| --prefix ${CASE}.scream.diags.hi \ | ||
| --prefix ${CASE}.scream.diags.h \ |
There was a problem hiding this comment.
You may want to try it out, but I think that CIME may expect the hist regex right after the model component name, so we may need scream.h.diags. Something to keep in mind if this does not work.
There was a problem hiding this comment.
I tried it out, the new regex works.
Our tests produce scream output only if the output testmods are used. Otherwise, no scream output. |
Great, so it's nicely encapsulated. I was hoping this was the case. |
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: jgfouca |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5782 FAILED (click to see last 100 lines of console output)SCREAM_PullRequest_Autotester_Weaver # 6008 PASSED (click to see last 100 lines of console output) |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: jgfouca |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5783 FAILED (click to see last 100 lines of console output)SCREAM_PullRequest_Autotester_Weaver # 6009 PASSED (click to see last 100 lines of console output) |
|
Diffs are expected. Merging. |
The file names in the output testmods were producing files that were getting skipped by CIME due to not matching the regex in config_archive.xml.
I was looking at the case SMS_Lh4.ne4_ne4.F2010-SCREAMv1.mappy_gnu.scream-output-preset-1 on mappy. The following scream hist outputs are produced:
None of these are recognized by CIME and are skipped. Here is the config_archive.xml entry for scream:
<hist_file_extension>hi\.(INSTANT|AVERAGE|MAX|MIN)\.n(step|sec|min|hour|day|month|year)s_x\d*\.\d{4}-\d{2}-\d{2}-\d{5}\.nc$</hist_file_extension>In CIME, this is processed into the regex:
scream\d?_?(\d{4})?\.hi\.(INSTANT|AVERAGE|MAX|MIN)\.n(step|sec|min|hour|day|month|year)s_x\d*\.\d{4}-\d{2}-\d{2}-\d{5}\.ncNote: in the hist files in the case, the words
diags,phys_dyn, andphysall appear in betweenscreamand.hi. Thehist_file_extensionis not set up to match those words, and so these files are all skipped.Based on slack conversation,
.hiis usually used for "history initialization" files, not output files, so we should use.hinstead in our scream output files.The new hist_file_extension will match ANY file with
screamfollowed by.h.and ending with.nc.