Skip to content

Call MPI_Abort in CIME runs when an exception is thrown inside EAMxx #2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Call MPI_Abort in CIME runs when an exception is thrown inside EAMxx #2984

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74a090c
EAMxx: call MPI_Abort in CIME runs when an exception is thrown inside…
bartgol Sep 5, 2024
70222af
EAMxx: in the fpe_guard_wrapper for CIME runs, capture all exceptions
bartgol Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion components/eamxx/src/mct_coupling/scream_cxx_f90_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,23 @@ void fpe_guard_wrapper (const Lambda& f) {
try {
f();
} catch (std::exception &e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to change this to catch (...) for greater generality?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we can do that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but I want to print the exception message.

Copy link
Contributor Author

@bartgol bartgol Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a rethrow, then add catch(...) underneath That didn't work, so I'm duplicating a bit the code to cover both needs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that work? Or do you need to nest try blocks?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but you might consider nesting try-catch blocks to avoid redundant code:

  try {
    try {
      throw std::exception();
    } catch (const std::exception& e) {
      printf("hi\n");
      throw;
    }
  } catch (...) {
    printf("hello\n");
  }

// Print exception msg, then call MPI_Abort
fprintf(stderr, "%s\n", e.what());

// Get raw comm before cleaning up singleton
auto& c = ScreamContext::singleton();
auto raw_comm = c.get<ekat::Comm>().mpi_comm();
c.clean_up();

MPI_Abort (raw_comm,1);
} catch (...) {

// Get raw comm before cleaning up singleton
auto& c = ScreamContext::singleton();
auto raw_comm = c.get<ekat::Comm>().mpi_comm();
c.clean_up();
throw;

MPI_Abort (raw_comm,1);
}

// Restore the FPE flag as it was when control was handed to us.
Expand Down