Sync lat/lon to host in rrtmgp interface for IOP #2995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lat/lon are used on both host and device in run_impl(), but when IOP is used we were changing the value without syncing to host.
bogensch
approved these changes
Sep 13, 2024
|
I tested on PM-GPU/CPU (this branch + revert P3-PR causing fails) and all passes. This only affects IOP code, so no surprise, and @bogensch tested for IOP runs and this resolves our issues. I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lat/lon are used on both host and device in run_impl(), but when IOP is used we were changing the value without syncing to host.