Skip to content

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Sep 18, 2024

These machines will be used soon for gh actions testing.

@bartgol bartgol added BFB Bit for bit Machine File AT: AUTOMERGE CI: skip eamxx-all Skip all eamxx testing for this PR labels Sep 18, 2024
@bartgol bartgol self-assigned this Sep 18, 2024
jgfouca
jgfouca previously approved these changes Sep 18, 2024
Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it is a LOT of effort, I recommend making the name slightly more specific. How about prefixing with snl-, so snl-ghci-...?

@mahf708
Copy link
Contributor

mahf708 commented Sep 18, 2024

Unless it is a LOT of effort, I recommend making the name slightly more specific. How about prefixing with snl-, so snl-ghci-...?

(a LOT of effort, e.g., rebuilding containers, etc., and other potential internal infra..)

tcclevenger
tcclevenger previously approved these changes Sep 18, 2024
@bartgol
Copy link
Contributor Author

bartgol commented Sep 18, 2024

Not a big effort at all. Coming right up

@bartgol bartgol dismissed stale reviews from tcclevenger and jgfouca via 1979f51 September 18, 2024 19:51
@bartgol bartgol force-pushed the bartgol/eamxx/test-all-ghci-snl-machines branch from 1979f51 to b4c9aab Compare September 18, 2024 20:05
Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for accommodating!

@bartgol bartgol merged commit 4e4cdf8 into master Sep 18, 2024
3 checks passed
@bartgol bartgol deleted the bartgol/eamxx/test-all-ghci-snl-machines branch September 18, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB Bit for bit CI: skip eamxx-all Skip all eamxx testing for this PR Machine File
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants