Skip to content

Small mods in test-all-scream related to baseline generation #3038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Small mods in test-all-scream related to baseline generation #3038

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e0148d
EAMxx: small mods in test-all-scream related to baseline generation
bartgol Oct 15, 2024
1161e21
EAMxx: no need to rm work dir when generating baselines
bartgol Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions components/eamxx/scripts/test_all_scream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ def generate_baselines(self, test):
f"Something is off. generate_baseline should have not be called for test {test}")

baseline_dir = self.get_test_dir(self._baseline_dir, test)
test_dir = self.get_test_dir(self._work_dir / "tas_baseline_build", test)
test_dir = self.get_test_dir(self._work_dir, test)
if test_dir.exists():
shutil.rmtree(test_dir)
test_dir.mkdir()
Expand Down Expand Up @@ -590,11 +590,6 @@ def generate_all_baselines(self):
print(f"Generating baselines using '{git_head}'")
print("###############################################################################")

tas_baseline_bld = self._work_dir / "tas_baseline_build"
if tas_baseline_bld.exists():
shutil.rmtree(tas_baseline_bld)
tas_baseline_bld.mkdir()

success = True
num_workers = len(tests_needing_baselines) if self._parallel else 1
with threading3.ProcessPoolExecutor(max_workers=num_workers) as executor:
Expand Down