-
Notifications
You must be signed in to change notification settings - Fork 54
Fixes a bug when copying grid data for a geo data of scalar type. #3059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a bug when copying grid data for a geo data of scalar type. #3059
Conversation
When copying the grid geo data from one grid to the another there is a check if the geo data has COL or not. This led to an error for the unique case of a geo data that is a scalar and thus the layout is essentially empty. This happens for DPxx cases.
@bogensch , this should fix the issue you were hitting w/ horizontal remapping of DPxx runs. I tested it w/ the DYCOMSrf01 case w/ the remap file you provided for me. |
@AaronDonahue thank you soooo much for working on this. So, this worked perfectly fine for me on pm-cpu (yay), but when I ran the exact same case on pm-gpu it seg faulted on initialization.... |
Thanks for checking on pm-gpu. Since our AT doesn't run a DPxx case w/ remapping I'll manually investigate and update the branch. |
Can confirm this works for me now on pm-gpu. Thanks!!! |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: AaronDonahue |
NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester... |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: AaronDonahue |
NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester... |
The AT timed out, but I verified that the mappy and weaver job actually passed. So I'll merge this, rather than get another round of testing. We've been testing a lot of PRs in the last 2 days, and we've been filling up scratch space faster than the clean up job can free it. So better save one run. |
When copying the grid geo data from one grid to the another there is a check if the geo data has COL or not. This led to an error for the unique case of a geo data that is a scalar and thus the layout is essentially empty.
This happens for DPxx cases.