Skip to content

Conversation

AaronDonahue
Copy link
Contributor

When copying the grid geo data from one grid to the another there is a check if the geo data has COL or not. This led to an error for the unique case of a geo data that is a scalar and thus the layout is essentially empty.

This happens for DPxx cases.

When copying the grid geo data from one grid to the another there is
a check if the geo data has COL or not.  This led to an error for the
unique case of a geo data that is a scalar and thus the layout is
essentially empty.

This happens for DPxx cases.
@AaronDonahue
Copy link
Contributor Author

@bogensch , this should fix the issue you were hitting w/ horizontal remapping of DPxx runs. I tested it w/ the DYCOMSrf01 case w/ the remap file you provided for me.

bartgol
bartgol previously approved these changes Oct 23, 2024
@bogensch
Copy link
Contributor

@AaronDonahue thank you soooo much for working on this. So, this worked perfectly fine for me on pm-cpu (yay), but when I ran the exact same case on pm-gpu it seg faulted on initialization....

@AaronDonahue
Copy link
Contributor Author

Thanks for checking on pm-gpu. Since our AT doesn't run a DPxx case w/ remapping I'll manually investigate and update the branch.

@bogensch
Copy link
Contributor

Can confirm this works for me now on pm-gpu. Thanks!!!

@E3SM-Bot
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 6215
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;bugfix;DP-SCREAM
PULLREQUESTNUM 3059
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 920b9b6
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 69c16bb
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5960
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;bugfix;DP-SCREAM
PULLREQUESTNUM 3059
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 920b9b6
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 69c16bb
TEST_REPO_ALIAS SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)
  • Branch: aarondonahue/fix_for_scalar_layout_w_horiz_remap
  • SHA: 920b9b6
  • Mode: TEST_REPO

Pull Request Author: AaronDonahue

@E3SM-Bot
Copy link
Collaborator

NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester...

@E3SM-Bot
Copy link
Collaborator

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

  • Build Num: 6219
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;bugfix;DP-SCREAM
PULLREQUESTNUM 3059
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 920b9b6
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 69c16bb
TEST_REPO_ALIAS SCREAM

Build Information

Test Name: SCREAM_PullRequest_Autotester_Mappy

  • Build Num: 5964
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS AT: AUTOMERGE;bugfix;DP-SCREAM
PULLREQUESTNUM 3059
SCREAM_SOURCE_REPO https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA 920b9b6
SCREAM_TARGET_BRANCH master
SCREAM_TARGET_REPO https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA 69c16bb
TEST_REPO_ALIAS SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)
  • Branch: aarondonahue/fix_for_scalar_layout_w_horiz_remap
  • SHA: 920b9b6
  • Mode: TEST_REPO

Pull Request Author: AaronDonahue

@E3SM-Bot
Copy link
Collaborator

NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester...

@bartgol
Copy link
Contributor

bartgol commented Oct 25, 2024

The AT timed out, but I verified that the mappy and weaver job actually passed. So I'll merge this, rather than get another round of testing. We've been testing a lot of PRs in the last 2 days, and we've been filling up scratch space faster than the clean up job can free it. So better save one run.

@bartgol bartgol merged commit 26b2b1e into master Oct 25, 2024
3 of 4 checks passed
@bartgol bartgol deleted the aarondonahue/fix_for_scalar_layout_w_horiz_remap branch October 25, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants