-
Notifications
You must be signed in to change notification settings - Fork 54
Fix ghci snl machine settings #3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add entry in config_machines.xml * Renamed to ghci-snl-cpu * Fix baselines location
Note: these settings seem to work well with AT2, and you can take a look to current actions runs on the SNL-hosted container here. The testing is correctly handling baselines for both standalone and v1, where baselines are stored on the physical machine (mappy) and mounted during testing (same for input data folder). The baselines location are different from the ones for actual mappy runs, so that we do not interfere with current AT1 runs. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
All Jobs Finished; status = PASSED, target_sha=26b2b1eae91247d02700e1d3edad459be7c4285e, However Inspection must be performed before merge can occur... |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
SCREAM_PullRequest_Autotester_Weaver # 6232 PASSED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Mappy # 5972 FAILED (click to see last 100 lines of console output)
|
Mappy is being slammed with testing lately. Things looked good, and the setting I changed in the last commit should not affect PASS/FAIL (it's for another machine). Merging. |
This PR prepares for running actions on a SNL-hosted CPU-only machine (a container that runs on mappy).
I'm going to let the AT run on this, since it also removes one leftover instance of kokkos 4 deprecated code (so it's not just adding a new machine). I am planning to have our CI disable deprecated code by default (I'd argue we should do it everywhere, but that's another story), so we'll need the fix anyways.
Note: all the paths in the config machine are relative to the container. That said, one can always run any container mounting local volumes to those paths, so it is not, strictly speaking, only for this container image.
I will share the container recipe somewhere else (only the part I implemented, since SNL adds some secret sauce on top...long story, ping me if your interested).
After this PR is merged, I will