Skip to content

Add workflow files for eamxx standalone and v1 testing #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 25, 2024
Merged

Add workflow files for eamxx standalone and v1 testing #3061

merged 5 commits into from
Oct 25, 2024

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Oct 23, 2024

This PR introduces the workflow files to run what is currently the AT tests as gh actions on SNL machines. Some comments:

  • So far, only testing for openmp on CPU: a container image for Nvidia GPU is currently being tested, and the actions will be updated once it's ready
  • I still need to add more v1 tests. On slack, we settled on having ~6 ERS tests. I will add those before this PR is ready to merge
  • The workflows run on pull_request as well as workflow_dispatch triggers. The latter can be used to generate baselines or simply to run master's tests. Additionally, the standalone workflow will have a schedule trigger, to submit to cdash (it's not there yet, cause I don't want to overlap with our jenkins infrastructure until I fully trust the actions).
  • gh actions checks will not be required for now, so that AT1 can continue to merge PRs while we gradually switch to actions
  • I added a composite action for test-all-scream. Although it adds very little compared to copy-pasting its content in the standalone workflow, it has a couple of steps related to artifacts upload. When the standalone testing will consist of several jobs (one per platform/arch or compiler), having these extra lines would make the workflow file clunkier. Encapsulating those lines in another file makes the workflow file easier to parse (hopefully).

I welcome questions/suggestions/contributions to make the transition smoother/better.

@bartgol bartgol added testing CI: skip eamxx-all Skip all eamxx testing for this PR AT: WIP labels Oct 23, 2024
@bartgol bartgol self-assigned this Oct 23, 2024
@bartgol bartgol removed the AT: WIP label Oct 25, 2024
@bartgol bartgol force-pushed the bartgol/ghci/eamxx-testing branch from 4a95778 to 15656e9 Compare October 25, 2024 19:26
@bartgol
Workflows: add action for test-all-scream
c41a48a 
The action does not do much, but it helps to keep the workflow
files under control. In particular, a couple of steps related to
artifacts uploading take a few lines. Having those steps inside
each job in a workflow file may make workflow a tad long to parse
@bartgol
Workflows: add workflow files for eamxx standalone and v1 testing
08e6039
@bartgol
Workflows: add more targeted ways to skip eamxx testing
54fa070
@bartgol
Workflows: fix mdlint for test-all-scream action
fe1a894
@bartgol
Workflows: add workflow to run scripts tests on ghci-snl-cpu
cff9601
@bartgol bartgol force-pushed the bartgol/ghci/eamxx-testing branch from 15656e9 to cff9601 Compare October 25, 2024 19:35
@bartgol bartgol merged commit 7a0f81f into master Oct 25, 2024
5 checks passed
@bartgol bartgol deleted the bartgol/ghci/eamxx-testing branch October 25, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgfouca jgfouca jgfouca approved these changes

@tcclevenger tcclevenger Awaiting requested review from tcclevenger

Assignees

@bartgol bartgol

Labels
CI: skip eamxx-all Skip all eamxx testing for this PR testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartgol @jgfouca