-
Notifications
You must be signed in to change notification settings - Fork 54
Change output specs for mam tests #3066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change output specs for mam tests #3066
Conversation
89c86f7
to
ed910a3
Compare
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
The baselines tests only check the first file, so put all snapshots in the same file, not just the t0 snap
It prevents us from running "make" or "ctest" in the intermediate layer folder
ed910a3
to
30b87a9
Compare
Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - A user has pushed a change to the PR before testing completed. NEW EVENT 'committed', ID C_kwDOCEfuetoAKDMwYjg3YTkwYTA2NDM2ZGZjYTM4YjIzOWViY2ZkMDhmZjc4YWY0OGY... The Jenkins Jobs will be shutdown; Testing of this PR must occur again. |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
SCREAM_PullRequest_Autotester_Weaver # 6234 ERROR (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Mappy # 5974 ERROR (click to see last 100 lines of console output)
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
The eamxx-sa gh action checks that fail are expected, since we are adding more snapshots to the nc files saved by those three tests, hence the diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Luca for fixing this!
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
SCREAM_PullRequest_Autotester_Weaver # 6235 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Mappy # 5975 FAILED (click to see last 100 lines of console output)
|
I am not sure why |
Failures are expected: one test wasn't blessed (but this PR does not touch it) and three baseline cmp were added. Merging |
The baselines tests only check the first file. So put all snapshots in the same file, not just the t0 snap, to make sure we're comparing the final state, not just the IC.