Change input file for standalone mam test #3079

bartgol · 2024-10-31T02:50:38Z

Tests were working since the file was present on our testbeds. On a new machine, it did not get downloaded.

singhbalwinder · 2024-10-31T03:28:40Z

.../multi-process/dynamics_physics/mam/homme_shoc_cld_spa_p3_rrtmgp_mam4_wetscav/CMakeLists.txt

  scream/init/spa_init_ne2np4.nc
  scream/init/spa_file_unified_and_complete_ne2np4L72_20231222.nc
  scream/init/${EAMxx_tests_IC_FILE_72lev}
+  scream/init/scream_unit_tests_aerosol_optics_ne2np4L72_20220822.nc


Can we use scream/init/${EAMxx_tests_IC_FILE_MAM4xx_72lev}

Suggested change

scream/init/scream_unit_tests_aerosol_optics_ne2np4L72_20220822.nc

scream/init/${EAMxx_tests_IC_FILE_MAM4xx_72lev}

It is a different file, so we might need to bless it, but it will be consistent with the rest of the testing.

That's fine with me. I'll push the change.

E3SM-Bot · 2024-10-31T03:43:28Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Build Num: 6258
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	testing;AT: skip eamxx-all
PULLREQUESTNUM	3079
SCREAM_SOURCE_REPO	https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA	`4d4f8e7`
SCREAM_TARGET_BRANCH	master
SCREAM_TARGET_REPO	https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA	`cb30379`
TEST_REPO_ALIAS	SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)

Pull Request Author: bartgol

E3SM-Bot · 2024-10-31T03:54:05Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Build Num: 6258
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	testing;AT: skip eamxx-all
PULLREQUESTNUM	3079
SCREAM_SOURCE_REPO	https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA	`4d4f8e7`
SCREAM_TARGET_BRANCH	master
SCREAM_TARGET_REPO	https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA	`cb30379`
TEST_REPO_ALIAS	SCREAM

E3SM-Bot · 2024-10-31T03:54:24Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
THE LAST COMMIT TO THIS PULL REQUEST HAS BEEN REVIEWED, BUT NOT ACCEPTED OR REQUIRES CHANGES!

E3SM-Bot · 2024-10-31T03:54:31Z

All Jobs Finished; status = PASSED, target_sha=cb30379332fb0a59dee9ab7105f6523f3575351e, However Inspection must be performed before merge can occur...

singhbalwinder

Thanks, @bartgol, for fixing it!

E3SM-Bot · 2024-10-31T05:00:46Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Build Num: 6260
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	testing;AT: skip eamxx-all
PULLREQUESTNUM	3079
SCREAM_SOURCE_REPO	https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA	`4606db3`
SCREAM_TARGET_BRANCH	master
SCREAM_TARGET_REPO	https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA	`cb30379`
TEST_REPO_ALIAS	SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)

Pull Request Author: bartgol

E3SM-Bot · 2024-10-31T05:11:37Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Build Num: 6260
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	testing;AT: skip eamxx-all
PULLREQUESTNUM	3079
SCREAM_SOURCE_REPO	https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA	`4606db3`
SCREAM_TARGET_BRANCH	master
SCREAM_TARGET_REPO	https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA	`cb30379`
TEST_REPO_ALIAS	SCREAM

E3SM-Bot · 2024-10-31T05:12:01Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Main Automerge is disabled (in .cfg file)

bartgol · 2024-10-31T06:06:06Z

@singhbalwinder You said using EAMxx_tests_IC_FILE_MAM4xx_72lev would require a bless. On weaver, the tests are passing. Did you expect a fail? Or are the contents of the two files the same?

singhbalwinder · 2024-10-31T06:33:56Z

The files are different; the original file was inputdata/atm/scream/init/scream_unit_tests_aerosol_optics_ne2np4L72_20220822.nc and we new file is inputdata/atm/scream/init/screami_unit_tests_mam4xx_ne2np4L72_20240329.nc. I expect it to fail. Could you please check, if possible, which nc files the test is comparing to conclude that it passed?

I did a diff of ncdump and I can see the diff in the files(cprnc doesn't work as one file has the time dimension defined differently ).

I will also run it manually and confirm if I get a pass or not.

E3SM-Bot · 2024-10-31T07:02:56Z

The base branch has been updated since the last successful testing.

last PASS base branch sha: cb30379
current base branch sha : 3146f7f
The AutoTester will discard the last PASS, and re-test the PR from scratch

E3SM-Bot · 2024-10-31T07:03:55Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Build Num: 6263
Status: STARTED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	testing;AT: skip eamxx-all
PULLREQUESTNUM	3079
SCREAM_SOURCE_REPO	https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA	`4606db3`
SCREAM_TARGET_BRANCH	master
SCREAM_TARGET_REPO	https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA	`cb30379`
TEST_REPO_ALIAS	SCREAM

Using Repos:

Repo: SCREAM (E3SM-Project/scream)

Pull Request Author: bartgol

E3SM-Bot · 2024-10-31T07:14:48Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Build Num: 6263
Status: PASSED

Jenkins Parameters

Parameter Name	Value
PR_LABELS	testing;AT: skip eamxx-all
PULLREQUESTNUM	3079
SCREAM_SOURCE_REPO	https://github.com/E3SM-Project/scream
SCREAM_SOURCE_SHA	`4606db3`
SCREAM_TARGET_BRANCH	master
SCREAM_TARGET_REPO	https://github.com/E3SM-Project/scream
SCREAM_TARGET_SHA	`cb30379`
TEST_REPO_ALIAS	SCREAM

E3SM-Bot · 2024-10-31T07:15:06Z

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Main Automerge is disabled (in .cfg file)

bartgol · 2024-10-31T14:25:25Z

@singhbalwinder in the eamxx-sa checks the test DID fail. I am a bit puzzled as of why it would pass on weaver (GPU) but fail on ghci-snl-cpu (CPU). I will run manually on weaver and see if something is amiss.

bartgol · 2024-10-31T15:11:18Z

@singhbalwinder I manually ran the test on weavere, and it did fail. I'm not sure why it passed for the AT...

Edit: LOL, I did not notice that the label AT: skip eamxx-all was on, so tests were not run... :) But that makes me wonder why the actions ran. Maybe our logic to skip based on label is not right in the workflows.

bartgol · 2024-10-31T15:12:57Z

Given that the tests pass when expected and diff when expected, I'm going to merge.

bartgol added testing CI: skip eamxx-all Skip all eamxx testing for this PR labels Oct 31, 2024

bartgol requested review from mahf708 and odiazib October 31, 2024 02:50

bartgol self-assigned this Oct 31, 2024

odiazib approved these changes Oct 31, 2024

View reviewed changes

EAMxx: ensure download of standalone input file

4d4f8e7

bartgol force-pushed the bartgol/eamxx/mam-input-file-download branch from 4d5e51b to 4d4f8e7 Compare October 31, 2024 03:21

bartgol requested a review from odiazib October 31, 2024 03:21

odiazib previously approved these changes Oct 31, 2024

View reviewed changes

singhbalwinder requested changes Oct 31, 2024

View reviewed changes

EAMxx: use standard mam4xx IC file for wetscav test too

4606db3

bartgol dismissed odiazib’s stale review via 4606db3 October 31, 2024 04:03

bartgol requested review from odiazib and singhbalwinder October 31, 2024 04:03

singhbalwinder approved these changes Oct 31, 2024

View reviewed changes

bartgol changed the title ~~Ensure download of standalone input file for mam~~ Change input file for standalone mam test Oct 31, 2024

bartgol merged commit e140df9 into master Oct 31, 2024
11 of 13 checks passed

bartgol deleted the bartgol/eamxx/mam-input-file-download branch October 31, 2024 15:13

	scream/init/scream_unit_tests_aerosol_optics_ne2np4L72_20220822.nc
	scream/init/${EAMxx_tests_IC_FILE_MAM4xx_72lev}

Change input file for standalone mam test #3079

Change input file for standalone mam test #3079

Uh oh!

Conversation

bartgol commented Oct 31, 2024

Uh oh!

singhbalwinder Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

bartgol Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

E3SM-Bot commented Oct 31, 2024

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Jenkins Parameters

Using Repos:

Uh oh!

E3SM-Bot commented Oct 31, 2024

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Jenkins Parameters

Uh oh!

E3SM-Bot commented Oct 31, 2024

Uh oh!

E3SM-Bot commented Oct 31, 2024

Uh oh!

singhbalwinder left a comment

Choose a reason for hiding this comment

Uh oh!

E3SM-Bot commented Oct 31, 2024

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Jenkins Parameters

Using Repos:

Uh oh!

E3SM-Bot commented Oct 31, 2024

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Jenkins Parameters

Uh oh!

E3SM-Bot commented Oct 31, 2024

Uh oh!

bartgol commented Oct 31, 2024

Uh oh!

singhbalwinder commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

E3SM-Bot commented Oct 31, 2024

Uh oh!

E3SM-Bot commented Oct 31, 2024

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Jenkins Parameters

Using Repos:

Uh oh!

E3SM-Bot commented Oct 31, 2024

Build Information

Test Name: SCREAM_PullRequest_Autotester_Weaver

Jenkins Parameters

Uh oh!

E3SM-Bot commented Oct 31, 2024

Uh oh!

bartgol commented Oct 31, 2024

Uh oh!

bartgol commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bartgol commented Oct 31, 2024

Uh oh!

Uh oh!

Uh oh!

singhbalwinder commented Oct 31, 2024 •

edited

Loading

bartgol commented Oct 31, 2024 •

edited

Loading