Skip to content

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Nov 5, 2024

This change has been made by @bartgol from the Mergify merge protections editor.

Copy link
Contributor

mergify bot commented Nov 5, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

Enforce checks passing

Make sure that checks are not failing on the PR, and reviewers approved

  • #approved-reviews-by >= 1
  • any of:
    • check-skipped=eamxx-sa/gcc-openmp/*
    • check-success=eamxx-sa/gcc-openmp/*
  • any of:
    • check-skipped=eamxx-sa/gcc-cuda/*
    • check-success=eamxx-sa/gcc-cuda/*
  • any of:
    • check-skipped=eamxx-v1/cpu-gcc/*
    • check-success=eamxx-v1/cpu-gcc/*
  • any of:
    • check-skipped=eamxx-scripts/cpu-gcc
    • check-success=eamxx-scripts/cpu-gcc
  • #changes-requested-reviews-by == 0

mahf708
mahf708 previously approved these changes Nov 5, 2024
Signed-off-by: Luca Bertagna <null>
@bartgol bartgol force-pushed the mergify/bartgol/config-update branch from 33961f0 to 8f96dfe Compare November 7, 2024 03:42
@bartgol bartgol force-pushed the mergify/bartgol/config-update branch from f7121f5 to 6f30ec5 Compare November 7, 2024 03:54
@bartgol bartgol requested a review from mahf708 November 7, 2024 03:56
@bartgol bartgol self-assigned this Nov 7, 2024
@bartgol
Copy link
Contributor Author

bartgol commented Nov 7, 2024

I'm gonna go ahead and merge, since Naser approved before, and this new version is just fixing syntax. Also, I want to test the configs on new PRs before the weekend.

@bartgol bartgol merged commit 5b14f5b into master Nov 7, 2024
9 of 10 checks passed
@bartgol bartgol deleted the mergify/bartgol/config-update branch November 7, 2024 18:45
@bartgol
Copy link
Contributor Author

bartgol commented Nov 7, 2024

Ok, after merging this, mergify seems to be doing the right thing on the PRs.
mergify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants