Skip to content

Conversation

bartgol
Copy link
Contributor

@bartgol bartgol commented Nov 7, 2024

Namely:

  • Add name entry for pre_process_pr steps
  • Ensure actual jobs run if pre_process_pr is skipped

This bug is what prevented nightlies to run last night on ghci-snl containers. It would also prevent us from regen baselines (workflow_dispatch), so this fix is somewhat urgent.

* Add name entry for pre_process_pr steps
* Ensure actual jobs run if pre_process_pr is skipped
@bartgol bartgol self-assigned this Nov 7, 2024
@bartgol bartgol added the CI: workflow change approved Allow testing of PRs that alter a worfklow file label Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

Enforce checks passing

Make sure that checks are not failing on the PR, and reviewers approved

  • any of:
    • check-skipped=eamxx-sa/gcc-openmp/*
    • check-success=eamxx-sa/gcc-openmp/*
  • any of:
    • check-skipped=eamxx-sa/gcc-cuda/*
    • check-success=eamxx-sa/gcc-cuda/*
  • any of:
    • check-skipped=eamxx-v1/cpu-gcc/*
    • check-success=eamxx-v1/cpu-gcc/*
  • any of:
    • check-skipped=eamxx-scripts/cpu-gcc
    • check-success=eamxx-scripts/cpu-gcc
  • #approved-reviews-by >= 1
  • #changes-requested-reviews-by == 0

@bartgol bartgol merged commit 59a42d3 into master Nov 8, 2024
16 of 17 checks passed
@bartgol bartgol deleted the bartgol/workflows/fix-eamxx-workflows branch November 8, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix CI: workflow change approved Allow testing of PRs that alter a worfklow file workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants