Skip to content

Conversation

oopsbagel
Copy link
Collaborator

Fixes issue #294

@oopsbagel oopsbagel closed this Jun 6, 2025
@oopsbagel
Copy link
Collaborator Author

I'm going to reopen this once #374 is merged :)

@oopsbagel oopsbagel reopened this Jun 6, 2025
Copy link
Collaborator

@cooperq cooperq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix format of commands

Copy link
Collaborator

@untitaker untitaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could the installer do this for you?

@oopsbagel
Copy link
Collaborator Author

I'm not sure why merging is blocked -- I can't dismiss @cooperq 's stale review, so he'll have to come approve it I guess.

@oopsbagel
Copy link
Collaborator Author

could the installer do this for you?

Technically yes but some people reported having to disable it to run the installer again. It's a slightly different mode with different rmnet settings so I'm not ready to make it the default.

We could definitely add a command to the installer under util to do it too.

@untitaker
Copy link
Collaborator

if reverting is needed to run the installer again then I think this should also be documented

@oopsbagel
Copy link
Collaborator Author

It's not inherently required, but a user reported they had to, so I will include it.

Copy link
Collaborator

@wgreenberg wgreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to clear the old stale review. thanks!

@wgreenberg wgreenberg merged commit bf2b00c into EFForg:main Jun 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants