Allow enabling/disabling analyzers from config file #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a simple way to be able to use the 2G analyzer in europe, and to disable maybe IMSI requests if they are too noisy. In a later version we can: * expose config editing in the UI (this is already ongoing) * make the level configurable * add ability to define presets (though i think people could just copy configs from the docs or github issues) Also fill out heuristics.md with some basic information.
wgreenberg
previously approved these changes
Jun 10, 2025
There was a problem hiding this comment.
i like this approach a lot! whenever i get around to finishing #183 and we have canonical identifiers for each heuristic, we can add backwards-compatible config entries for the names we have here.
|
also added two nitpick copy edits, feel free to take or leave them |
Co-authored-by: Will Greenberg <willg@eff.org>
wgreenberg
approved these changes
Jun 10, 2025
|
@wgreenberg if you have a WIP branch on heuristics versioning i can take a look and finish it. i probably need to tear this code up again if i impl some other features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple way to be able to use the 2G analyzer in europe,
and to disable maybe IMSI requests if they are too noisy.
In a later version we can:
configs from the docs or github issues)
Also fill out heuristics.md with some basic information.