feat: support Tmobile TMOHS1 hotspot #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oopsbagel
force-pushed
the
tmobile-tmohs1
branch
3 times, most recently
from
8974190 to
412719c
Compare
|
Oops, I didn't actually intend to mark this ready for review until I included the refactors mentioned above. I could handle those in a separate PR but I'd rather do it here. |
oopsbagel
force-pushed
the
tmobile-tmohs1
branch
4 times, most recently
from
6e5f2cf to
8f42035
Compare
oopsbagel
requested review from
untitaker,
wgreenberg,
gaykitty and
cooperq
and removed request for
untitaker and
wgreenberg
untitaker
previously approved these changes
Jun 25, 2025
untitaker
previously approved these changes
Jun 25, 2025
|
Just tested on my TMOHS1 and it worked great! One suggestion, having a special error message for a wrong password would be nice. |
|
Ready to merge this as soon as you rebase @oopsbagel |
cooperq
previously approved these changes
Jul 16, 2025
Add support for the Tmobile TMOHS1, a Wingtech CT2MHS01-based hotspot with a Qualcomm mdm9607. The TMOHS1 has no screen, only 5 LEDs, two of which are RGB.
The Tmobile TMOHS1 is clearly based on the Wingtech CT2MHS01, and thus the installation process looks very similar between them.
These were originally excluded because they weren't tested, as they are subsets of bands 25, 26, and 66, but are worth enumerating.
oopsbagel
force-pushed
the
tmobile-tmohs1
branch
from
7dc9495 to
509023a
Compare
cooperq
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the Tmobile TMOHS1, a Wingtech CT2MHS01-based hotspot with a Qualcomm mdm9607. The TMOHS1 has no screen, only 5 LEDs, two of which are RGB.
This pull request is a draft until #387 is merged, because it uses common installer code and makes modifications to some of the same files (like
display/src/mod.rs).I will refactor out some of the other commonalities in the installer between this and the Wingtech before merging.