Add ZIP download endpoint #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
force-pushed
the
zip-download
branch
2 times, most recently
from
55a0a59 to
12e1b19
Compare
|
IMO ideally we'd have a combined dropdown + button, where if you click the button you get the ZIP by default, but there's advanced options to get PCAP and QMDL. I tried and failed to implement that using |
untitaker
force-pushed
the
zip-download
branch
2 times, most recently
from
2337014 to
20308f6
Compare
cooperq
previously approved these changes
Jun 23, 2025
wgreenberg
approved these changes
Jun 23, 2025
bin/src/server.rs
Outdated
|
|
||
| tokio::spawn(async move { | ||
| let result: Result<(), Error> = async { | ||
| let mut zip2 = ZipFileWriter::with_tokio(writer); |
There was a problem hiding this comment.
leftover from the porting effort from zip to async-zip. renamed to just zip
| .take(qmdl_size_bytes as u64) | ||
| }; | ||
|
|
||
| copy(&mut qmdl_file, &mut entry_writer).await?; |
bin/src/server.rs
Outdated
| { | ||
| let entry = | ||
| ZipEntryBuilder::new(format!("{qmdl_idx}.qmdl").into(), Compression::Stored); | ||
| let mut entry_writer = zip2.write_entry_stream(entry).await?.compat_write(); |
There was a problem hiding this comment.
i'm not sure i understand what compat_write() is doing -- honestly it was hard even finding where the method's coming from. maybe add a comment explaining it?
wgreenberg
requested changes
Jun 23, 2025
wgreenberg
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #409
don't know what to do with the other buttons. just remove?