Avoid rustcrypto backend for release builds #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonft
reviewed
Sep 21, 2025
Comment on lines
39
to
42
| cargo build-daemon-firmware-devel | ||
| # Alternatively, if you have a cross-compilation toolchain for C installed, | ||
| # you can build it exactly like in CI: | ||
| # CC_armv7_unknown_linux_musleabihf=arm-linux-gnueabihf-gcc cargo build-daemon-firmware |
There was a problem hiding this comment.
Is it worth adding a warning here about the risks of building and using the -devel version, or should it wait until it's actually sending sensitive data?
There was a problem hiding this comment.
you're probably right, not sure how to explain it succinctly though
There was a problem hiding this comment.
How about this:
The rustcyrpto library, though not known to be insecure, is less well tested than its counterpart and could potentially have severe issues in its cryptographic implementation. We therefore recommend using ring-tls in production builds.
cooperq
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #549