Skip to content

Commit 56ed471

Browse files
committed
Issue #16 start avoiding "UDP" terminology
1 parent b020a9e commit 56ed471

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

algorithm_catalog/worldcereal_inference.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@
8484
"linkTemplates": [],
8585
"links": [
8686
{
87-
"rel": "openeo-udp",
87+
"rel": "openeo-process",
8888
"type": "application/json",
89-
"title": "openEO UDP",
89+
"title": "openEO Process Definition",
9090
"href": "https://github.com/ESA-APEX/apex_algorithms/blob/main/openeo_udp/worldcereal_inference.json"
9191
},
9292
{

qa/tools/apex_algorithm_qa_tools/scenarios.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,10 @@ def lint_benchmark_scenario(scenario: BenchmarkScenario):
7676
raise ValueError(
7777
f"Invalid github.com based namespace {namespace!r}: should be a raw URL"
7878
)
79-
# Inspect UDP URL
80-
udp_resp = requests.get(namespace)
81-
udp_resp.raise_for_status()
82-
assert udp_resp.json()["id"] == node["process_id"]
79+
# Inspect openEO process definition URL
80+
resp = requests.get(namespace)
81+
resp.raise_for_status()
82+
# TODO: also support process listings?
83+
assert resp.json()["id"] == node["process_id"]
8384
# TODO: check that github URL is a "pinned" reference
84-
# TODO: check that provided parameters match expected parameters from UDP
85+
# TODO: check that provided parameters match expected process parameters

qa/unittests/tests/test_algorithm_catalog.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ def test_lint_algorithm_catalog_json_file(path):
1919

2020
assert data["properties"]["type"] == "apex_algorithm"
2121

22-
assert "openeo-udp" in {k["rel"] for k in data["links"]}
22+
assert "openeo-process" in {k["rel"] for k in data["links"]}
2323
# TODO more checks

qa/unittests/tests/test_openeo_udp.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,4 @@ def test_lint_openeo_udp_json_file(path):
2020
assert "parameters" in data
2121
assert "process_graph" in data
2222
# TODO more checks
23+
# TODO require a standardized openEO "type"? https://github.com/Open-EO/openeo-api/issues/539

0 commit comments

Comments
 (0)