Skip to content

Commit a16f14f

Browse files
committed
upload_assets: upload with "public-read" ACL (#5)
1 parent 6a9d561 commit a16f14f

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

qa/tools/apex_algorithm_qa_tools/pytest_upload_assets.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,13 @@ def _upload(self, collector: _Collector):
9696
key = f"{self.run_id}!{nodeid}!{name}"
9797
# TODO: get upload info in report?
9898
_log.info(f"Uploading {path} to {self.bucket}/{key}")
99-
self.s3_client.upload_file(Filename=str(path), Bucket=self.bucket, Key=key)
99+
self.s3_client.upload_file(
100+
Filename=str(path),
101+
Bucket=self.bucket,
102+
Key=key,
103+
# TODO: option to override ACL, or ExtraArgs in general?
104+
ExtraArgs={"ACL": "public-read"},
105+
)
100106

101107

102108
@pytest.fixture

0 commit comments

Comments
 (0)