Skip to content

Commit a59f09e

Browse files
committed
Issue #152: set pipefail in benchmarks.yaml
to avoid losing `pytest`'s exit code due to the `| tee` (from #104) Note: setting `shell: bash` also enables pipefail according to the documentation, but it doesn't hurt to be a bit more explicit here.
1 parent 91eb3e6 commit a59f09e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/benchmarks.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ jobs:
2323
python -m pip install -r qa/benchmarks/requirements.txt
2424
- name: Run benchmark pytest suite
2525
continue-on-error: true
26+
shell: bash
2627
run: |
28+
set -o pipefail
2729
cd qa/benchmarks
2830
mkdir report
2931
mkdir tmp_path_root
@@ -48,7 +50,7 @@ jobs:
4850

4951
- name: Issue Generation
5052
env:
51-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
53+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5254
run: |
5355
if grep -q "FAILED" qa/benchmarks/pytest_output.txt; then
5456
python qa/tools/apex_algorithm_qa_tools/test_failure_handler.py

0 commit comments

Comments
 (0)