test_failure_handler improvements

[soxofaan]

apex_algorithms/.github/workflows/benchmarks.yaml

Lines 55 to 59 in c6e12ea

	if grep -q "FAILED" qa/benchmarks/pytest_output.txt; then
	python qa/tools/apex_algorithm_qa_tools/test_failure_handler.py
	else
	echo "No test failures detected"
	fi

Why doing this "FAILED" grep in bash, which makes things more error prone and harder to maintain. I would just do the "FAIL" detection directly in test_failure_handler.py.

Also: I would pass the pytest_output.txt path explicitly to the test_failure_handler.py script instead of brittle hardcoding of a relative path it in the script:

apex_algorithms/qa/tools/apex_algorithm_qa_tools/test_failure_handler.py

Line 203 in c6e12ea

log_file = Path("qa/benchmarks/pytest_output.txt")

[soxofaan]

with this built-in if condition

apex_algorithms/.github/workflows/benchmarks.yaml

Lines 52 to 53 in c3868cc

	- name: Issue Generation
	if: ${{ failure() }}

(as added by e16e711 for #152)
I guess it's probably easier to just remove the whole if grep -q "FAILED" qa/benchmar... else... guard as the step will now only run on failure anyway