Address reviewer comments

cacraigucar · cacraigucar · commit 4ec89a550352 · 2025-04-18T11:07:57.000-06:00
diff --git a/.gitmodules b/.gitmodules
@@ -20,7 +20,7 @@
 [submodule "ncar-physics"]
         path          = src/physics/ncar_ccpp
 	url           = https://github.com/ESCOMP/atmospheric_physics
-	fxtag         = a131fb880
+	fxtag         = 36f336e87
         fxrequired    = AlwaysRequired
         fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics
 [submodule "ccs_config"]
diff --git a/cime_config/testdefs/testmods_dirs/cam/outfrq_dme_adjust_derecho/user_nl_cam b/cime_config/testdefs/testmods_dirs/cam/outfrq_dme_adjust_derecho/user_nl_cam
@@ -2,6 +2,6 @@ ncdata='/glade/campaign/cesm/community/amwg/sima_baselines/cam_sima_test_snapsho
 ncdata_check='/glade/campaign/cesm/community/amwg/sima_baselines/cam_sima_test_snapshots/cam_ne3pg3_dme_adjust_snapshot_derecho_gnu_after_c20250416.nc'
 debug_output=0
 pver=32
-hist_add_inst_fields;h2: Q,T,U,V,PS
+hist_add_inst_fields;h2: Q,T
 hist_output_frequency;h2: nsteps
 hist_write_nstep0;h2: .true.
diff --git a/src/physics/ncar_ccpp b/src/physics/ncar_ccpp
@@ -1 +1 @@
-Subproject commit 9f453e6acb08c842d70a3fafadfa2082e45bc2f6
+Subproject commit 36f336e876ece9fcfcb97a29cf1785d172a5252d
diff --git a/test/existing-test-failures.txt b/test/existing-test-failures.txt
@@ -1,4 +1 @@
-SMS_Ln9.ne5pg3_ne5pg3_mg37.FCAM7.derecho_intel.cam-outfrq_se_cslam_analy_ic (Overall: FAIL) details:
-SMS_Ln9.ne5pg3_ne5pg3_mg37.FCAM7.derecho_gnu.cam-outfrq_se_cslam_analy_ic (Overall: FAIL) details:
-- CAM7 suite will not work without a PBL scheme
-- CAM7 suite will not work with snapshot fields in registry.xml even if initial_value is defined (CAM-SIMA#359)
+All tests are currently passing
