Fix isssue-closing script to work without project pages and default merge messages. #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
added
Github action
peverwhee
reviewed
Aug 20, 2024
peverwhee
approved these changes
Aug 20, 2024
mwaxmonsky
requested changes
Aug 21, 2024
There was a problem hiding this comment.
One or two things I think might be worth while and one change I'm happy to help look into a bit more to make the number tracking simpler.
Great work @nusbaume!
mwaxmonsky
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Looks great @nusbaume, thanks for taking this on!
One or two minor suggestions but nothing that should hold this up any longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue-closing script in CAM-SIMA so that it will now successfully close issues or PRs in the non-default branch when issues are referenced in the PR message with a relevant keyword. This will happen both without any attachment to a particular Github project, and with any PR commit message.
Fixes #279
Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the boundary datasets: N/A
Describe any substantial timing or memory changes: N/A
Code reviewed by: peverwhee, mwaxmonsky
List all existing files that have been modified, old files eliminated, new files added and describe the changes:
M .github/workflows/branch_push_workflow.yml
- Update Github Action and Python versions.
M .github/scripts/branch_pr_issue_closer.py
- Update issue-closing script to work without projects or default PR commit messages.
derecho/intel/aux_cam: All pass.
derecho/gnu/aux_cam: All pass.
Summarize any changes to answers, i.e.,
what code configurations: N/A
what platforms/compilers: N/A
nature of change (roundoff; larger than roundoff but same climate; new climate): N/A