Skip to content

Conversation

cacraigucar
Copy link
Collaborator

Tag name (required for release branches):
Originator(s): cacraig

Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the input datasets (e.g. boundary datasets): N/A

List all files eliminated and why: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
M src/data/ref_pres.F90
M src/dynamics/utils/vert_coord.F90
M src/physics/utils/physics_grid.F90
- removed unnecessary NPES > 1 checks

If there are new failures (compared to the test/existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?

derecho/intel/aux_sima: All Pass

derecho/gnu/aux_sima: All Pass

If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:

CAM-SIMA date used for the baseline comparison tests if different than latest:

@cacraigucar cacraigucar requested a review from nusbaume April 18, 2025 22:55
@cacraigucar cacraigucar self-assigned this Apr 18, 2025
@cacraigucar cacraigucar added the code clean-up Made code simpler, better, and/or easier to read. label Apr 18, 2025
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar!

@nusbaume nusbaume requested a review from peverwhee April 22, 2025 03:08
Copy link
Collaborator

@peverwhee peverwhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @cacraigucar !

@cacraigucar cacraigucar merged commit 41072c1 into ESCOMP:development Apr 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code clean-up Made code simpler, better, and/or easier to read.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants