Skip to content

PIO reader class cleanup #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 31, 2025
Merged

PIO reader class cleanup #408

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8bb53d9
Add new 'atmos_phys' submodule with updated file_reader interface.
nusbaume Jul 17, 2025
9656c58
Update PIO CCPP FileIO implementation and unit tests to use allocatab…
nusbaume Jul 18, 2025
6cac1c6
Fix syntax error in file reader unit test routines.
nusbaume Jul 18, 2025
b61c356
Refactor dimension size acquisition for integer and real interfaces.
nusbaume Jul 23, 2025
b17d993
Refactor dimension acquisition for character interfaces.
nusbaume Jul 23, 2025
7356510
Update the reader object to be constructed as a pointer, not an alloc…
nusbaume Jul 25, 2025
2a29ce4
Check for reader association, not allocation.
nusbaume Jul 25, 2025
0afb223
Fix syntax error.
nusbaume Jul 25, 2025
63748ec
Remove branch from github workflow file.
nusbaume Jul 25, 2025
91af6c0
Merge remote-tracking branch 'upstream/development' into pio_reader_u…
nusbaume Jul 31, 2025
46dc27d
Update comments as requested during code review.
nusbaume Jul 31, 2025
e07134d
Update submodule to point to official atmospheric_physics repo.
nusbaume Jul 31, 2025
4ce8d93
Update character array comments as requested during code review.
nusbaume Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
fxDONOTUSEurl = https://github.com/MPAS-Dev/MPAS-Model.git
[submodule "ncar-physics"]
path = src/physics/ncar_ccpp
url = https://github.com/ESCOMP/atmospheric_physics
fxtag = e92f76351e7f7703fb6d91cb5e76dcbbc6dcb3f2
url = https://github.com/nusbaume/atmospheric_physics
fxtag = 0aba4349625d53604fd7f1230d01f39821464169
fxrequired = AlwaysRequired
fxDONOTUSEurl = https://github.com/ESCOMP/atmospheric_physics
[submodule "rrtmgp-data"]
Expand Down Expand Up @@ -119,4 +119,3 @@
fxtag = v0.1.4
fxrequired = ToplevelRequired
fxDONOTUSEurl = https://github.com/NCAR/CUPiD.git

2 changes: 1 addition & 1 deletion src/physics/ncar_ccpp
Open in desktop
Submodule ncar_ccpp updated 13 files
+567 −518 doc/NamesNotInDictionary.txt
+137 −57 phys_utils/ccpp_io_reader.F90
+4 −4 schemes/cloud_fraction/compute_cloud_fraction.F90
+4 −4 schemes/cloud_fraction/compute_cloud_fraction.meta
+3 −3 schemes/rasch_kristjansson/cloud_particle_sedimentation.F90
+4 −4 schemes/rasch_kristjansson/cloud_particle_sedimentation.meta
+2 −2 schemes/rasch_kristjansson/prognostic_cloud_water.meta
+6 −6 schemes/rasch_kristjansson/rk_stratiform.F90
+7 −7 schemes/rasch_kristjansson/rk_stratiform.meta
+1 −1 schemes/tj2016/tj2016_sfc_pbl_hs.meta
+1 −1 schemes/zhang_mcfarlane/zm_conv_evap.meta
+1 −1 schemes/zhang_mcfarlane/zm_convr.meta
+10 −6 test/test_schemes/file_io_test.F90
Loading
Loading