Skip to content

Commit f426849

Browse files
authored
Merge pull request #3902 from adrifoster/landuse_driver_bugfix
ctsm5.4.034: bug fix to the FATES land use driver input code
2 parents 1fc4af4 + 7fb7a15 commit f426849

4 files changed

Lines changed: 59 additions & 1 deletion

File tree

cime_config/testdefs/ExpectedTestFails.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,20 @@
191191
<issue>ESCOMP/mizuRoute#613</issue>
192192
</phase>
193193
</test>
194+
195+
<test name="SMS_D_Ld5.5x5_amazon_rHDMA.I2000Clm60SpMizGs.derecho_gnu.mizuroute-default">
196+
<phase name="NLCOMP">
197+
<status>FAIL</status>
198+
<issue>ESMCI/cime#4966</issue>
199+
</phase>
200+
</test>
201+
202+
<test name="SMS_D_Ld5.5x5_amazon_rHDMA.I2000Clm60SpMizGs.derecho_intel.mizuroute-default">
203+
<phase name="NLCOMP">
204+
<status>FAIL</status>
205+
<issue>ESMCI/cime#4966</issue>
206+
</phase>
207+
</test>
194208

195209
<test name="SMS_D_Ld5.5x5_amazon_rHDMA.I2000Clm60SpMizGs.izumi_nag.mizuroute-default">
196210
<phase name="MODEL_BUILD">

doc/ChangeLog

Lines changed: 43 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,47 @@
11
===============================================================
2+
Tag name: ctsm5.4.034
3+
Originator(s): afoster (Adrianna Foster,UCAR/TSS,303-497-1728)
4+
Date: Wed Apr 22 11:02:13 AM MDT 2026
5+
One-line Summary: bug fix to the FATES land use driver input code
6+
7+
Purpose and description of changes
8+
----------------------------------
9+
10+
This PR includes a cherry-picked fix from NorESMhub/CTSM#209 to address swap in the
11+
order of rangeland and pasture in the reading of the landuse drivers
12+
13+
14+
Bugs fixed
15+
----------
16+
17+
List of CTSM issues fixed (include CTSM Issue # and description):
18+
Resolves FATES https://github.com/NGEET/fates/issues/1551
19+
20+
21+
Testing summary:
22+
----------------
23+
24+
regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):
25+
26+
derecho ----- OK
27+
izumi ------- OK
28+
29+
fates tests: (give name of baseline if different from CTSM tagname, normally fates baselines are fates-<FATES TAG>-<CTSM TAG>)
30+
derecho ----- OK
31+
izumi ------- OK
32+
33+
Added 2 new expected fails for mizuroute NLCOMP DIFFs.
34+
35+
36+
Answer changes
37+
--------------
38+
39+
Changes answers relative to baseline:
40+
41+
Landuse tests are not B4B, otherwise B4B
42+
43+
===============================================================
44+
===============================================================
245
Tag name: ctsm5.4.033
346
Originator(s): glemieux (Gregory Lemieux, LBNL, glemieux@lbl.gov)
447
Date: Fri Apr 17 10:39:02 AM MDT 2026

doc/ChangeSum

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
Tag Who Date Summary
22
============================================================================================================================
3+
ctsm5.4.034 afoster 04/22/2026 bug fix to the FATES land use driver input code
34
ctsm5.4.033 glemieux 04/17/2026 Update fates tag with missing land use data check fix
45
ctsm5.4.032 samrabin 04/10/2026 Simplify doc build messaging.
56
ctsm5.4.031 samrabin 04/09/2026 b4b-dev merge 2026-04-09

src/utils/clmfates_interfaceMod.F90

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3939,7 +3939,7 @@ subroutine GetLandusePFTData(bounds, landuse_pft_file, landuse_pft_map, landuse_
39393939

39403940
! Land use name arrays
39413941
character(len=10), parameter :: landuse_pft_map_varnames(num_landuse_pft_vars) = &
3942-
[character(len=10) :: 'frac_primr','frac_secnd','frac_pastr','frac_range'] !need to move 'frac_surf' to a different variable
3942+
[character(len=10) :: 'frac_primr','frac_secnd','frac_range','frac_pastr'] !need to move 'frac_surf' to a different variable
39433943

39443944
character(len=*), parameter :: subname = 'GetLandusePFTData'
39453945

0 commit comments

Comments
 (0)