-
Notifications
You must be signed in to change notification settings - Fork 341
ctsm5.3.081: Some namelist default changes for clm6_0 physics #3549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctsm5.3.081: Some namelist default changes for clm6_0 physics #3549
Conversation
…2024 forcing and historical period
|
Whoops this ended up including changes on b4b-dev again. So I might need to redo this and create a new PR... |
0de4339 to
d8c3f53
Compare
|
One unexpected fail: ERP_D_P64x2_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default--clm-matrixcnOn_ignore_warnings in the sparse matrix. We've seen this before. |
|
65 tests are different: 13 tests that show differences because at least irrigate was changed: 15 tests where c13_timeseries was turned on: |
slevis-lmwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ekluzek. I had one comment motivated by reduced code clutter.
Before approving, I also wanted to confirm resolution of the unexpected fail that you posted here #3549 (comment)
ekluzek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment from our discussion from Monday
This is the someone screwy matrix test with threading on that has known problems. It can sometimes fail, but will pass on resubmit. So this isn't something we should worry about. But, I did rerun to confirm that and it passed on resubmission. I'm now resending aux_clm. |
slevis-lmwg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekluzek and I worked together on updating some comments. Now I can approve.
@slevis-lmwg and I went through this to make it clearer.
…SM into ciso_namelist_default_changes
|
OK, testing is as expected on Derecho and Izumi. Some tests only differ in the field list (because C13/C14 was switched). So only the following tests show difference answers as expected because of the irrigate change: Tests that have different answers because C13/C14 timeseries files were turned on (for just C13/C14 fields): So all tests are as expected. |
|
I didn't change anything in python code for this to fail. But, I'm seeing 11 of 117 the python system tests for subsetdata failing here, when the ctsm5.3.080 works fine. I'll look at this more to see if it could be something I changed. But, if I don't see it, I may merge it in anyway... |
|
#3205 gave the answer to the python system testing problem above. A couple of the files weren't pulled from LFS correctly. And I just needed to pull them in again. |
Description of changes
Only turn C13/C14 for clm6_0 and BGC, and also require the DATM forcing to be CRUJRA2024 or CAM7 and for the historical period. So for example SSP compsets won't have C13/C14 on, single point compsets won't, or for using older forcing (like CAM6, or GSWP3v1, Qian, or CRUv7). Also whenever use_c13 or use_c14 is on turn on the corresponding time series file.
Also change default for irrigate to on for historical SP/BGC cases.
Specific notes
Contributors other than yourself, if any: @wwieder @slevis-lmwg
CTSM Issues Fixed (include github issue #):
Fixes #3527
Fixes #3551
Some work on #3346
Are answers expected to change (and if so in what way)? Yes
by default C13/C14 won't be on as much
Irrigation will be on for historical SP/BGC cases
Any User Interface Changes (namelist or namelist defaults changes)?
Namelist defaults change for use_c13/use_c14 so only on for clm6_0 Bgc, for CRUJRA2024 or CAM7 forcing historical period.
Name default changes for clm60 for HistClm60Sp/HistClm60Bgc compsets so irrigation is on
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: So far running build-namelist tests. Will run aux_clm also