ctsm5.4.034: bug fix to the FATES land use driver input code

[adrifoster]

Description of changes

This PR includes a cherry-picked fix from NorESMhub/CTSM #209 to address swap in the order of rangeland and pasture in the reading of the landuse drivers.

Specific notes

Contributors other than yourself, if any: @rosiealice

Are answers expected to change (and if so in what way)? Yes - for FATES land use runs

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

testing starting

[samsrabin]

Nice

[adrifoster]

okay well it's hard to tell if this is working as intended because we don't have any LUH tests that don't die in the RUN phase?

[glemieux]

okay well it's hard to tell if this is working as intended because we don't have any LUH tests that don't die in the RUN phase?

@adrifoster I talked about this with @ckoven yesterday. I could have a "quick" fix for this that would require an update to the LUH datasets and the FATES code. I'll start working on that; what do you think about holding on this until that's updated?

[samsrabin]

That seems like a reasonable approach to me, especially considering the b4b-dev merge is supposed to happen today.

[rosiealice]

Just to confirm that this code change is what we implemented in NorESM and that it's all working fine there. But agree that this might be a good reason to create the relevant working tests!

[glemieux]

Just to confirm that this code change is what we implemented in NorESM and that it's all working fine there. But agree that this might be a good reason to create the relevant working tests!

@rosiealice @mvdebolskiy Do y'all run the tests are we see failing here: #3789 (comment)?

[mvdebolskiy]

@glemieux no, we don't and the latest NorESM has not yet been updated to 5.4.030.

[mvdebolskiy]

@rosiealice it is fine only because we did not yet updated to sam's files.

[samsrabin]

This PR will come in after @glemieux fixes the FATES land use tests, which will happen in a separate master tag.

[glemieux]

The FATES-side fix appears to be working. I'll make the PR on the fates side for review and link it here.

[adrifoster]

All tests have now passed or fail as expected.