Skip to content

Fix bug. Sometimes the content type isn't sent. #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

Fix bug. Sometimes the content type isn't sent. #228

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d8a141
Fix bug. Sometimes the content type isn't sent.
JosePineiro Jul 15, 2025
c19a64c
Update src/literals.h
JosePineiro Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AsyncWebServerRequest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ void AsyncWebServerRequest::send(FS &fs, const String &path, const char *content

// Handle compressed version
const String gzPath = path + asyncsrv::T__gz;
File gzFile = fs.open(gzPath, "r");
File gzFile = fs.open(gzPath, fs::FileOpenMode::read);

// Compressed file not found or invalid
if (!gzFile.seek(gzFile.size() - 8)) {
Expand Down
6 changes: 3 additions & 3 deletions src/WebResponses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ AsyncFileResponse::AsyncFileResponse(FS &fs, const String &path, const char *con
}
}

if (*contentType != '\0') {
if (*contentType == '\0') {
_setContentTypeFromPath(path);
} else {
_contentType = contentType;
Expand All @@ -745,11 +745,11 @@ AsyncFileResponse::AsyncFileResponse(FS &fs, const String &path, const char *con
int filenameStart = path.lastIndexOf('/') + 1;
char buf[26 + path.length() - filenameStart];
char *filename = (char *)path.c_str() + filenameStart;
snprintf_P(buf, sizeof(buf), PSTR("attachment; filename=\"%s\""), filename);
snprintf(buf, sizeof(buf), T_attachment, filename);
addHeader(T_Content_Disposition, buf, false);
} else {
// Serve file inline (display in browser)
addHeader(T_Content_Disposition, PSTR("inline"), false);
addHeader(T_Content_Disposition, T_inline, false);
}

_code = 200;
Expand Down
3 changes: 3 additions & 0 deletions src/literals.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ namespace asyncsrv {

static constexpr const char *empty = "";

static const char T_inline[] = "inline";
static const char T_attachment[] = "attachment; filename=\"%s\"";

static constexpr const char *T__opaque = "\", opaque=\"";
static constexpr const char *T_100_CONTINUE = "100-continue";
static constexpr const char *T_13 = "13";
Expand Down