Skip to content

Fix Content-Disposition header causing files to download instead of play inline #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix Content-Disposition header causing files to download instead of play inline #231

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d98d92c
Initial plan
Copilot Jul 17, 2025
d99576f
Fix Content-Disposition header causing files to download instead of p…
Copilot Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/WebResponses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,10 +747,9 @@ AsyncFileResponse::AsyncFileResponse(FS &fs, const String &path, const char *con
char *filename = (char *)path.c_str() + filenameStart;
snprintf(buf, sizeof(buf), T_attachment, filename);
addHeader(T_Content_Disposition, buf, false);
} else {
// Serve file inline (display in browser)
addHeader(T_Content_Disposition, T_inline, false);
}
// For inline display, don't set Content-Disposition header
// Browser will display inline by default when download=false

_code = 200;
}
Expand Down Expand Up @@ -782,10 +781,10 @@ AsyncFileResponse::AsyncFileResponse(File content, const String &path, const cha

if (download) {
snprintf_P(buf, sizeof(buf), PSTR("attachment; filename=\"%s\""), filename);
} else {
snprintf_P(buf, sizeof(buf), PSTR("inline"));
addHeader(T_Content_Disposition, buf, false);
}
addHeader(T_Content_Disposition, buf, false);
// For inline display, don't set Content-Disposition header
// Browser will display inline by default when download=false
}
Copy link

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing brace for the AsyncFileResponse constructor appears to be missing its function body termination. The code structure suggests this brace should be followed by the function body continuation, but the diff shows it as a standalone addition.

Copilot uses AI. Check for mistakes.

size_t AsyncFileResponse::_fillBuffer(uint8_t *data, size_t len) {
Expand Down
Loading