Fix: Refactor AsyncFileResponse (File overload) #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors a single overload of the AsyncFileResponse constructor. The changes improve speed, readability and maintainability by: - Replacing the strlen(contentType) == 0 check - Restructuring the logic for setting the Content-Disposition header. Explicitly separates inline serving from download attachments. - Not altering behavior.
mathieucarbou
approved these changes
Aug 22, 2025
mathieucarbou
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AsyncFileResponse constructor overload to improve performance and code maintainability while preserving existing behavior. The changes optimize string operations and clarify the logic for setting Content-Disposition headers.
- Optimizes empty string check by replacing
strlen(contentType) == 0with*contentType == '\0' - Restructures Content-Disposition header logic to clearly separate inline serving from download attachments
- Replaces hardcoded strings with template constants and simplifies buffer handling
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mathieucarbou
requested changes
Aug 22, 2025
used Arduino String + reserve() + heap allocation
mathieucarbou
approved these changes
Aug 25, 2025
|
Thanks a lot @JosePineiro 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a single overload of the AsyncFileResponse constructor. The changes improve speed, readability and maintainability by: