Fix for issue #7242 : broken translations for enums in forms#7243
Fix for issue #7242 : broken translations for enums in forms#7243FoxCie wants to merge 1 commit intoEasyCorp:4.xfrom
Conversation
With symfony/form >= v7.3.5, EnumType uses the keys of the choices option as labels for the enum cases, breaking the translation that happened previously when enum implements TranslatableInterface. The translation now occurs only when the choices option has integer keys (more precisely, currently only if it satisfies array_list()). Fixing this by changing the way ChoiceFields are configured with the ChoiceConfigurator, to define the choices option with integer keys when the enum is translatable.
| // When dealing with enums that implement TranslatableInterface, they are now translated by Symfony only if | ||
| // the keys of the choices are integers. |
There was a problem hiding this comment.
This sounds like a bug in Symfony?
There was a problem hiding this comment.
They acknowledged that the previous behaviour was actually the bug. When dealing with choices, the keys of the array should be the labels. It is not explicit on EnumType, but on its parent ChoiceType, the doc states that clearly :
Source : https://symfony.com/doc/current/reference/forms/types/choice.html#choices .
The thing is that it was actually impossible to change an enum's labels with the choices array with the previous behaviour. Now it is possible, but the old behaviour is still present if the keys are integers (e.g. when giving the ::cases() as the choices).
EDIT : the associated bug in Symfony is here : symfony/symfony#61927 .
There was a problem hiding this comment.
This still looks wrong to me. The EnumType should transform the data to make it compatible with ChoiceType
There was a problem hiding this comment.
It is what is done. It is just the label that can be changed by passing a string value as the key of the array. EnumType does what should be done so that the values are properly handled and converted. If you think this is not appropriate, you could open an issue on the Symfony side.
3 participants
With symfony/form >= v7.3.5, EnumType uses the keys of the choices option as labels for the enum cases, breaking the translation that happened previously when enum implements TranslatableInterface. The translation now occurs only when the choices option has integer keys (more precisely, currently only if it satisfies array_list()). Fixing this by changing the way ChoiceFields are configured with the ChoiceConfigurator, to define the choices option with integer keys when the enum is translatable.