Skip to content

Comments

Use renderAsLink() instead of asTextLink() for Action::DELETE#7273

Open
bt-nn wants to merge 1 commit intoEasyCorp:4.xfrom
bt-nn:patch-2
Open

Use renderAsLink() instead of asTextLink() for Action::DELETE#7273
bt-nn wants to merge 1 commit intoEasyCorp:4.xfrom
bt-nn:patch-2

Conversation

@bt-nn
Copy link
Contributor

@bt-nn bt-nn commented Dec 3, 2025

fixes #7120

@bt-nn
Copy link
Contributor Author

bt-nn commented Dec 3, 2025

CustomActionOrderTest::testIndexPageEntityActionsOrder is failing, because the Delete Button in now solid.

@javiereguiluz javiereguiluz added this to the 4.x milestone Dec 4, 2025
@javiereguiluz
Copy link
Collaborator

The delete button is intended to be rendered as a link instead of a solid button ... bUT, it should be rendered at the leftmost position of the buttons. In fact, the now-failing test shows that: the "text + danger" deletea ction is the last one.

So, I need to look into the original issue to find the cause of that issue and an alternative solution. Thanks!

@bt-nn
Copy link
Contributor Author

bt-nn commented Dec 4, 2025

Doesn’t it look a bit inconsistent that this is the only element not displayed as a button
(see the screenshots in #7120)?

If this is the intended behavior, it would be great if
EasyCorp\Bundle\EasyAdminBundle\Config\Action::TextLink could also work with false,
so that we can adjust the rendering in our admins.

Thanks for your great work on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't render Delete button as button

2 participants