PHPCS fixes #3
Open
PHPCS fixes #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrijith
suggested changes
Jun 10, 2019
inc/class-markdown-hb-import.php
Outdated
| if ( class_exists( 'WP_CLI' ) ) { | ||
| \WP_CLI::success( "Successfully created {$created} command pages." ); | ||
| \WP_CLI::success( sprintf( 'Successfully created %s command pages.', $created ) ); |
There was a problem hiding this comment.
Suggested change
| \WP_CLI::success( sprintf( 'Successfully created %s command pages.', $created ) ); | |
| \WP_CLI::success( "Successfully created {$created} command pages." ); |
Why is current implementation changed? Current code is clearer.
| 'post_type' => $this->post_type, | ||
| 'post_parent' => $parent_page_id, | ||
| 'posts_per_page' => 200, | ||
| 'posts_per_page' => 200, // phpcs:ignore |
There was a problem hiding this comment.
Why is it ignored? Add comment with specific rule.
There was a problem hiding this comment.
This actually throughs warning.
While running PHPCS I am not getting any specific rule with a warning (Please check above screenshot). Any idea how do I get a specific rule to ignore?
| public function ee_wpghs_whitelisted_post_types( $supported_post_types ) { | ||
|
|
||
| return [ | ||
| 'handbook', |
There was a problem hiding this comment.
Could we use $this->post_type here and other instances where possible ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.