fix/android-has-permission #175

Author: EddyVerbruggen

demo/app/main-page.xml

@@ -7,9 +7,9 @@
           <ScrollView>
             <GridLayout columns="*,*" rows="auto, auto, auto, auto, auto, auto, auto, auto, auto, auto" horizontalAlignment="center" class="tab-content">
 
+              <Label row="0" colSpan="2" text="You need permission before being able to schedule local notifications. Either defer to when you schedule it, or do it when the app first loads." class="hint" textWrap="true" />
+              <Button row="1" col="0" text="has permission?" tap="{{ doCheckHasPermission }}" class="button button-neutral"/>
               <iOS>
-                <Label row="0" colSpan="2" text="On iOS you need permission before being able to schedule local notifications. Either defer to when you schedule it, or do it when the app first loads." class="hint" textWrap="true" />
-                <Button row="1" col="0" text="has permission?" tap="{{ doCheckHasPermission }}" class="button button-neutral"/>
                 <Button row="1" col="1" text="request perm." tap="{{ doRequestPermission }}" class="button button-neutral"/>
               </iOS>
 

src/local-notifications.android.ts

@@ -78,9 +78,7 @@ export class LocalNotificationsImpl extends LocalNotificationsCommon implements
   hasPermission(): Promise<boolean> {
     return new Promise((resolve, reject) => {
       try {
-        const context = utils.ad.getApplicationContext();
-        const hasPermission = NotificationManagerCompatPackageName.NotificationManagerCompat.from(context).areNotificationsEnabled();
-        resolve(hasPermission);
+        resolve(LocalNotificationsImpl.hasPermission());
       } catch (ex) {
         console.log("Error in LocalNotifications.hasPermission: " + ex);
         reject(ex);
@@ -91,7 +89,7 @@ export class LocalNotificationsImpl extends LocalNotificationsCommon implements
   requestPermission(): Promise<boolean> {
     return new Promise((resolve, reject) => {
       try {
-        // nothing to do on this platform
+        // AFAIK can't do it on this platform
         resolve(true);
       } catch (ex) {
         console.log("Error in LocalNotifications.requestPermission: " + ex);
@@ -198,6 +196,11 @@ export class LocalNotificationsImpl extends LocalNotificationsCommon implements
   schedule(scheduleOptions: ScheduleOptions[]): Promise<Array<number>> {
     return new Promise((resolve, reject) => {
       try {
+        if (!LocalNotificationsImpl.hasPermission()) {
+          reject("Permission not granted");
+          return;
+        }
+
         const context = utils.ad.getApplicationContext();
         const resources = context.getResources();
         const scheduledIds: Array<number> = [];
@@ -243,6 +246,11 @@ export class LocalNotificationsImpl extends LocalNotificationsCommon implements
       }
     });
   }
+
+  private static hasPermission(): boolean {
+    const context = utils.ad.getApplicationContext();
+    return !context || NotificationManagerCompatPackageName.NotificationManagerCompat.from(context).areNotificationsEnabled();
+  }
 }
 
 export const LocalNotifications = new LocalNotificationsImpl();

src/local-notifications.ios.ts

@@ -439,6 +439,8 @@ export class LocalNotificationsImpl extends LocalNotificationsCommon implements
           this.requestPermission().then(granted => {
             if (granted) {
               resolve(LocalNotificationsImpl.schedulePendingNotifications(options));
+            } else {
+              reject("Permission not granted");
             }
           });
         } else {

src/package.json

@@ -1,6 +1,6 @@
 {
   "name": "nativescript-local-notifications",
-  "version": "4.0.1",
+  "version": "4.1.0",
   "description": "The Local Notifications plugin allows your app to show notifications when the app is not running. Just like remote push notifications, but a few orders of magnitude easier to set up.",
   "main": "local-notifications",
   "typings": "index.d.ts",
@@ -60,9 +60,9 @@
   },
   "homepage": "https://github.com/eddyverbruggen/nativescript-local-notifications",
   "devDependencies": {
-    "nativescript-dev-typescript": "rc",
-    "tns-core-modules": "rc",
-    "tns-platform-declarations": "rc",
+    "nativescript-dev-typescript": "~0.10.0",
+    "tns-core-modules": "~6.1.2",
+    "tns-platform-declarations": "~6.1.2",
     "tslint": "^5.10.0",
     "typescript": "~3.4.5"
   }