Add default utf-8 charset to node file responses #4486
+25
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
I noticed that by default the node platform
HttpServerResponse.file
sets just e.g. "text/html" as the content type, which prevents e.g. some browsers from displaying emojis correctly.To be clear specification doesn't specify any behavior.
As per chatgpt, we should be able to safely add a default charset attribute with any content type coming from the "mime" package, the client should just ignore it in case of non-textual responses.
This is my proposition to correct this problem.
Related