Fix spurious continue in the debug mode #75
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the problem I came across when tried to use the debugger on MacOS with arm64. When Lua hit breakpoint it captured it though the program execution did not stop since the debug loop exited almost instantly. Debug prints showed that this happened due to the spurious wake ups of the conditional variable `cvRun`. None of the methods notified this conditional so it seems it is a spurious wake up. Probably it is specific to the architecture. This small patch fixes this by adding a predicate to the conditional variable. It waits until the debugging is finished or there are evals to run.
georgiy-belyanin
added a commit
to tarantool/tarantool-vscode
that referenced
this pull request
Jun 14, 2025
This patch introduces basic Tarantool debugging facilities into the extension. Basically it is done using EmmyLuaDebugger [^1]. Set up the debugger using the following instructions. * Insert debugger code in Tarantool application by pressing `Ctrl+Shift+P` (or `Cmd+Shift+P` on MacOS) and running `Tarantool: Insert debugger code` command. * Start single Tarantool instance. * Press `F5` or run `Debug: Start debugging` command by pressing `Ctrl+Shift+P` (or `Cmd+Shift+P` on MacOS). * Choose `EmmyLua New Debugger` in the list. This debugging configuration would run automatically from now. * Set up breakpoints & access the Tarantool instance through `Debug console` in the bottom panel. These features are supported. * Breakpoints. * Step-by-step execution within the fiber. * Multiple files support. * Interacting with the local variables, console at the debug mode. Needs EmmyLua/EmmyLuaDebugger#75 to be tested on MacOS on arm64. Closes #19 [^1] EmmyLua/EmmyLuaDebugger#75
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the problem I came across when tried to use the
debugger on MacOS with arm64. When Lua hit breakpoint it captured it
though the program execution did not stop since the debug loop exited
almost instantly.
Debug prints showed that this happened due to the spurious wake ups of
the conditional variable
cvRun. None of the methods notified thisconditional so it seems it is a spurious wake up. Probably it is
specific to the architecture.
This small patch fixes this by adding a predicate to the conditional
variable. It waits until the debugging is finished or there are
evals to run.