Skip to content

[Bug] Notifications fail to show with notify-send #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jbeich opened this issue Feb 10, 2024 · 6 comments · May be fixed by #521
Open

[Bug] Notifications fail to show with notify-send #383

jbeich opened this issue Feb 10, 2024 · 6 comments · May be fixed by #521
Labels
bug Something isn't working

Comments

@jbeich
Copy link

jbeich commented Feb 10, 2024

Describe the bug
Regressed by #304 (6dafd54, functions.vala). Affects notify-send (from libnotify) but not noti. Creating notifications via notify-send doesn't work unless swaync is launched with -c /null .

To Reproduce

  1. Install swaync into a pristine container / jail
  2. Run swaync &
  3. Run notify-send "summary" "body"

Expected behavior

  1. Do something... shown on terminal
  2. A window pops up with titled summary with text body

Please provide logs if you're experiencing notification errors / bugs

$ G_MESSAGES_DEBUG=all HOME=$(mktemp -dt swaync-test) swaync
[...]
** (swaync:1234): DEBUG: notiDaemon.vala:171: Notification:
category:                (null)
image_data:              false
expire_timeout:          -1
replaces_id:             0
desktop_entry:           (null)
body:                   body
app_icon:
action_icons:            false
time:                   1707594987
hints:
        sender-pid: int64 86534
        urgency: byte 0x01
applied_id:              1
image_path:              (null)
inline-reply:            (null)
app_name:                notify-send
summary:                 summary
icon_data:               false
resident:                false
default_action:          (null)
actions:
urgency:                 Normal

Desktop

  • OS: FreeBSD (any version)
  • Version: swaync 0.10.0
$ pkg info -d swaync
swaync-0.10.0:
        pango-1.50.14
        libhandy-1.6.2_2
        gtk3-3.24.41
        gtk-layer-shell-0.8.2
        granite-6.2.0_2
        gdk-pixbuf2-2.42.10_2
        cairo-1.17.4_2,3
        libgee-0.20.6_1
        json-glib-1.8.0
        glib-2.78.4,2
        gettext-runtime-0.22.3_1
        pulseaudio-16.1_2
        at-spi2-core-2.50.1
@jbeich jbeich added the bug Something isn't working label Feb 10, 2024
@ErikReider
Copy link
Owner

ErikReider commented Feb 11, 2024 •
edited
Loading

So you're saying that the changes to the execute_command in that PR is what's causing notifications not to show? Or am I misunderstanding the issue?

Could you provide a video?

I'm not experiencing this at all on my two machines so it's pretty difficult to debug without more information

@MrPenguin07
Copy link
Contributor

Unable to reproduce here on master (simply launch via sway config exec swaync)

@ErikReider ErikReider mentioned this issue Mar 2, 2025
Closed
@ErikReider
Copy link
Owner

@jbeich made some changes to the function in the linked commit that you provided. Could you test it again?

@jbeich
Copy link
Author

jbeich commented Mar 3, 2025 •
edited
Loading

main branch (as of v0.10.1-33-g046e895) is still affected. dc7cd1a seems to break exec with multi-word values like sleep 1 but it's unrelated (except for debugging below).

Additional observation: changing run-on from receive to action in example-script (from default config) seems to help. Keeping receive but changing echo ... to sleep 1 also helps. Maybe there's a race: calling add_watch before spawn_async_with_pipes does help.

@ErikReider ErikReider linked a pull request Mar 3, 2025 that will close this issue
Draft
@ErikReider
Copy link
Owner

Can you check if #521 fixes anything?

@jbeich
Copy link
Author

jbeich commented Mar 3, 2025 •
edited
Loading

f04a239 from #521 doesn't help.

Reminds me, d0998d0 fixed terminal output. It now prints Do something... but the notifications are still not visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exec command fixes ErikReider/SwayNotificationCenter
3 participants
@jbeich @ErikReider @MrPenguin07