[DRAFT] Workaround fractional scaling completely breaking top_margin positioning #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the anchor point to the bottom screen edge if the top_margin value is greater than 0.5. This makes the issue less noticeable when the top_margin value is close to 0 or close to 1 (like the default 0.85), but doesn't fix the issue. The issue is still very apparent when the top_margin value is 0.5 or close to it.
Ferdi265
force-pushed
the
workaround-margin-fractional-scale
branch
from
c9d1484 to
e9b8dbc
Compare
|
Rebase off of main and is this still needed? |
|
shouldn't be needed any more with GTK4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the anchor point to the bottom screen edge if the top_margin value is greater than 0.5. This makes issue #101 less noticeable when the top_margin value is close to 0 or close to 1 (like the default 0.85), but doesn't fix the issue. The issue is still very apparent when the top_margin value is 0.5 or close to it.
I'm not sure this issue can be fixed completely as long as GTK doesn't support fractional scaling.
This PR is still WIP as I'm also working on finding a fix for the inconsistent window size issue when notification content changes and these issues should probably be fixed together.