Skip to content

Update to zbus 5.0 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2025
Merged

Update to zbus 5.0 #122

merged 1 commit into from
Jan 19, 2025

Conversation

werdahias
Copy link
Contributor

@Ferdi265 would you mind reviewing ?

@werdahias werdahias force-pushed the zbus-5 branch 3 times, most recently from ab67536 to 5a35427 Compare January 17, 2025 16:15
Ferdi265
Ferdi265 reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Ferdi265 Ferdi265 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't gotten to try out your branch yet, but from a quick glance I see one place where something could be off: AFAIK the input backend is on the DBus system bus, not the session bus, since it doesn't run as a regular user. I'll check that later.

@Ferdi265
Copy link
Contributor

Haven't gotten to try out your branch yet, but from a quick glance I see one place where something could be off: AFAIK the input backend is on the DBus system bus, not the session bus, since it doesn't run as a regular user. I'll check that later.

Yup, confirmed this. swayosd-libinput-backend.service fails to launch without the above change.

Ferdi265
Ferdi265 suggested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@Ferdi265 Ferdi265 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, see the individual comments. With this change, swayosd works fine, including the input backend, with updated zbus.

@werdahias
Copy link
Contributor Author

Yeah; I actually missed that. Fixed now

@Ferdi265
Copy link
Contributor

Yeah; I actually missed that. Fixed now

it looks like your recent push didn't actually change anything. git diff 5a35427..0b153a8 comes up empty.

@ErikReider
Copy link
Owner

Yeah; I actually missed that. Fixed now

it looks like your recent push didn't actually change anything. git diff 5a35427..0b153a8 comes up empty.

Seeing the same thing. One it's fixed, I'll merge :)

@werdahias
Copy link
Contributor Author

Fixed now

ErikReider
ErikReider approved these changes Jan 19, 2025
View reviewed changes
Copy link
Owner

@ErikReider ErikReider left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Appreciate the help with the review @Ferdi265 :D

@ErikReider ErikReider merged commit b70fd54 into ErikReider:main Jan 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErikReider ErikReider ErikReider approved these changes

+1 more reviewer

@Ferdi265 Ferdi265 Ferdi265 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@werdahias @Ferdi265 @ErikReider