Use bus name instead of Identity for playerctl compatibility #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried your version and |
|
@ErikReider do you think we could merge this? |
ErikReider
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #132 by manually looping through the players until one with the user-provided name is found.
Since this is what the output of
playerctl -llooks like, this simply makes the name compatible with the playerctl CLI which most people are likely using:Previously, the internal players had to be named the exact Identity (e.g., "Mozilla Firefox" or "Spotify"), for this to work. After this PR, users will be able to use the names from
playerctl -lto control the player they wish.