Skip to content

Update extension icon #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kellyhutchins opened this issue Sep 29, 2023 · 8 comments · May be fixed by #69
Open

Update extension icon #41

kellyhutchins opened this issue Sep 29, 2023 · 8 comments · May be fixed by #69
Labels
good first issue Good for newcomers

Comments

@kellyhutchins
Copy link
Member

Currently we use a default esri icon. This issue is to identify and replace it with a more meaningful icon. Once a new icon has been identified it can be updated using the icon option in package. json

@kellyhutchins kellyhutchins self-assigned this Sep 29, 2023
@hhkaos hhkaos added the good first issue Good for newcomers label Oct 4, 2024
@kimmykokonut
Copy link

kimmykokonut commented Oct 17, 2024

Is the goal to have it be one of Esri's icons/logos or to design something specific? I'm happy to look into this once I know the desired icon.

If it's ArcGIS, maybe that logo?
image

Or this icon I found on the ArcGIS blog: Screenshot 2024-10-17 at 1 29 47 PM

Or the SDK logo on the microsoft store for their ArcGIS Maps SDK for .NET Samples:
image

@hhkaos
Copy link
Member

hhkaos commented Oct 18, 2024

Hi Kim!

Good question.

  • The first one. actually is not a valid Esri logo as I stated here 😄 .
  • The second one is the right one. Attached at high resolution below.
  • The third one is the one used for the ArcGIS Maps SDK for Native SDKs :).

Thanks!
arcgis-maps-sdk-for-javascript-256 (1)

@kimmykokonut
Copy link

Thank you for the clarification. So the desire is the blue JS icon? If so, I can take this on. I wasn't sure if there was a plan to design a new one, which I do not feel qualified to do outside of Esri.

@hhkaos
Copy link
Member

hhkaos commented Oct 20, 2024

Right, the desired one is the last one with the "JS".

So please, feel free to start working on it.
Thanks! 😄

@hhkaos
Copy link
Member

hhkaos commented Oct 24, 2024

hi @kimmykokonut, let me know if you need any help with this 🙂

@nooras
Copy link
Contributor

nooras commented Feb 25, 2025

Hi @hhkaos
Is it open to work on? Shall i raise a PR for this? Can u please let me know on which page icon needs to update?

@hhkaos
Copy link
Member

hhkaos commented Feb 25, 2025

yes it is!, the icon is referenced in https://github.com/Esri/arcgis-js-vscode-snippets/blob/master/package.json#L20 . So, it should be as simple as uploading this icon to the repo and make sure the package.json is pointing to it 😄

@nooras
Copy link
Contributor

nooras commented Mar 4, 2025

Hi @hhkaos
how can I verify in local that newly added image is working fine?

nooras pushed a commit to nooras/arcgis-js-vscode-snippets that referenced this issue Mar 4, 2025
@nooras nooras linked a pull request Mar 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants