BugFix: Fixing BasemapGallery Sceneview appears blank sometimes. #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor NotifySpatialReferenceChanged method calls for improved asynchronous handling.
prathameshnarkhede
changed the title
… avoids multiple invocations of UpdateBasemaps() and NotifySpatialReferenceChanged()
dotMorten
reviewed
Jun 17, 2025
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryController.cs
Outdated
Show resolved
Hide resolved
Moved Cancellation operation to get semaphopre release earlier
mstefarov
reviewed
Jun 18, 2025
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryController.cs
Outdated
Show resolved
Hide resolved
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryController.cs
Outdated
Show resolved
Hide resolved
If another update is in progress, the method exits immediately.
mstefarov
reviewed
Jun 26, 2025
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryController.cs
Outdated
Show resolved
Hide resolved
…to make sure collate subsequent update calls and make it a single call.
dotMorten
reviewed
Jun 30, 2025
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryController.cs
Outdated
Show resolved
Hide resolved
dotMorten
reviewed
Jun 30, 2025
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryController.cs
Outdated
Show resolved
Hide resolved
…oading property to manage the loading state. This change simplifies and consolidating it into a single property.
dotMorten
approved these changes
Jul 1, 2025
mstefarov
approved these changes
Jul 1, 2025
prathameshnarkhede
deleted the
pratham/fix-Basemap-Gallery-Scene-View-Appearance-missing-SceneView
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a semaphore for thread-safe access to UpdateBasemaps.
This avoids multiple invocations of UpdateBasemaps() and NotifySpatialReferenceChanged() and locks resource when in use by another call.
Did testing by opening SceneView multipel times and did not observed the bug.