Skip to content

fix: parameters concatenation format and encode uri POST data #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: parameters concatenation format and encode uri POST data #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions es/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class FlowApi {
apiKey: this.apiKey,
...params
};
let data = this.getPack(params, method);
let data = this.getPack(params);
let sign = this.sign(params);
let response;
if (method == "GET") {
Expand All @@ -42,7 +42,7 @@ class FlowApi {
}
});
}
getPack(params, method) {
getPack(params) {
const keys = Object.keys(params)
.map(key => key)
.sort((a, b) => {
Expand All @@ -52,13 +52,9 @@ class FlowApi {
});
let data = [];
keys.map(key => {
if (method == "GET") {
data.push(
encodeURIComponent(key) + "=" + encodeURIComponent(params[key])
);
} else {
data.push(key + "=" + params[key]);
}
data.push(
encodeURIComponent(key) + "=" + encodeURIComponent(params[key])
);
});
return data.join("&");
}
Expand All @@ -72,9 +68,9 @@ class FlowApi {
});
let toSign = [];
keys.map(key => {
toSign.push(key + "=" + params[key]);
toSign.push(key + params[key]);
});
toSign = toSign.join("&");
toSign = toSign.join("");

return CryptoJS.HmacSHA256(toSign, this.secretKey);
}
Expand Down