fix: add graphql valid object annotation to all input and output types #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/unit/should_consolidate_input_and_output_types/expected.kt
ameerabdul
reviewed
Apr 26, 2024
| @@ -18,6 +18,7 @@ interface QueryCompletableFuture { | |||
| fun nonNullableResolver(arg: InputTypeGenerateFieldResolverInterfaces): java.util.concurrent.CompletableFuture<String> | |||
| } | |||
|
|
|||
| @GraphQLValidObjectLocations(locations = [GraphQLValidObjectLocations.Locations.INPUT_OBJECT]) | |||
There was a problem hiding this comment.
why does this need this annotation INPUT_OBJECT. This doesn't end with Input and also this is an interface.
There was a problem hiding this comment.
This class is generated from this type which is an input
There was a problem hiding this comment.
Basically any input that doesn't have a matching type is going to get this annotation
There was a problem hiding this comment.
And vice versa - any type that doesn't have a matching input will get @GraphQLValidObjectLocations(locations = [GraphQLValidObjectLocations.Locations.OBJECT])
There was a problem hiding this comment.
Will add detailed docs on this later
ameerabdul
approved these changes
Apr 26, 2024
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
@GraphQLValidObjectLocationsto restrict the use of a schema class as an input or output. With schema-first development, we want to enforce that schema is defined first up front. Thus we always want to be intentional about how the generated classes can be used.🔗 Related Issues