Skip to content

feat: include DataFetchingEnvironment in all resolver interface functions #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

danadajian
Copy link
Collaborator

@danadajian danadajian commented Apr 29, 2024

📝 Description

  • By default, include DataFetchingEnvironment as an additional argument to resolver functions, since all resolvers should have access to this.

@danadajian danadajian requested a review from a team as a code owner April 29, 2024 12:55
@danadajian danadajian changed the title feat: include DataFetchingEnvironment in all resolver interface funct… feat: include DataFetchingEnvironment in all resolver interface functions Apr 29, 2024
@danadajian danadajian merged commit 4f2e06a into main Apr 29, 2024
1 check passed
@danadajian danadajian deleted the default-include-datafechingenv branch April 29, 2024 21:18
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

danadajian added a commit that referenced this pull request Apr 30, 2024
BREAKING CHANGES:
* Generate open class rather than interface for types with field arguments
* Remove extraResolverArguments config, which is redundant following feat: include DataFetchingEnvironment in all resolver interface functions #52
* Rename resolverTypes config to resolverClasses and change its schema
danadajian added a commit that referenced this pull request Apr 30, 2024
BREAKING CHANGE: Generate open class rather than interface for types with field arguments
BREAKING CHANGE: Remove extraResolverArguments config, which is redundant following #52
BREAKING CHANGE: Rename resolverTypes config to resolverClasses and change its schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants