Skip to content

fix: support reserved kotlin keywords #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2024
Merged

fix: support reserved kotlin keywords #83

merged 4 commits into from
Jun 12, 2024

Conversation

danadajian
Copy link
Collaborator

@danadajian danadajian commented Jun 12, 2024 •
edited
Loading

📝 Description

  • Adds support for schema fields and type names which are reserved keywords in Kotlin.

🔗 Related Issues

@danadajian danadajian changed the title fix: support hard kotlin keywords (fixes #82) fix: support hard kotlin keywords to fix #82 Jun 12, 2024
@danadajian danadajian changed the title fix: support hard kotlin keywords to fix #82 fix: support hard kotlin keywords to (fixes https://github.com/ExpediaGroup/graphql-kotlin-codegen/issues/82) Jun 12, 2024
@danadajian danadajian changed the title fix: support hard kotlin keywords to (fixes https://github.com/ExpediaGroup/graphql-kotlin-codegen/issues/82) fix: support hard kotlin keywords Jun 12, 2024
@danadajian danadajian linked an issue Jun 12, 2024 that may be closed by this pull request
Types with reserved keywords 'is' and 'as' are generated incorrectly #82
Closed
@danadajian danadajian changed the title fix: support hard kotlin keywords fix: support reserved kotlin keywords Jun 12, 2024
@danadajian danadajian force-pushed the support-hard-keywords branch from bef640b to 9452b3b Compare June 12, 2024 01:38
@danadajian danadajian marked this pull request as ready for review June 12, 2024 02:15
@danadajian danadajian requested a review from a team as a code owner June 12, 2024 02:15
@danadajian danadajian merged commit d173cef into main Jun 12, 2024
1 check passed
@danadajian danadajian deleted the support-hard-keywords branch June 12, 2024 14:04
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

danadajian added a commit that referenced this pull request Jun 14, 2024
@danadajian
fix: support reserved kotlin keywords (#83)
5e7ff5b 
* unit test

* implement the fix

* implement the fix

* rename unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types with reserved keywords 'is' and 'as' are generated incorrectly
1 participant
@danadajian