Skip to content

Ktor 3.xx support #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ronjunevaldoz opened this issue Sep 28, 2024 · 1 comment
Closed

Ktor 3.xx support #2037

ronjunevaldoz opened this issue Sep 28, 2024 · 1 comment
Labels
type: enhancement New feature or request

Comments

@ronjunevaldoz
Copy link

Is your feature request related to a problem? Please describe.
8.0.0 is currently based on ktor 2.x.x

Describe the solution you'd like
I'd like to have a full support for ktor 3.x.x
@ronjunevaldoz ronjunevaldoz added the type: enhancement New feature or request label Sep 28, 2024
This was referenced Sep 29, 2024
Closed
Closed
@daniel-humla daniel-humla mentioned this issue Nov 4, 2024
Merged
samuelAndalon pushed a commit that referenced this issue Nov 7, 2024
@daniel-humla
Upgrade to kotlin 2 (#2054)
275e2ab 
### 📝 Description

- Upgrade kotlin to 2.0
- Remove unused file
[FieldValueInfosExtensions.kt](https://github.com/ExpediaGroup/graphql-kotlin/compare/master...daniel-humla:graphql-kotlin-kotlin-2:upgrade-to-kotlin-2?expand=1#diff-83598ed0250eac913ae661abe96bcc47c344e342f09f8168341c7728d1c5b2ef)
- Added minimal additional test
[MetadataCapturingDataFetcherFactoryProviderTest.kt](https://github.com/ExpediaGroup/graphql-kotlin/compare/master...daniel-humla:graphql-kotlin-kotlin-2:upgrade-to-kotlin-2?expand=1#diff-8a648bcb4be11526cc310472dbca7a5a26ff15b7a8e5c15668d5f9e19debb18e)
to maintain code coverage

### 🔗 Related Issues
#2037
@TheDome0 TheDome0 mentioned this issue Nov 10, 2024
Closed
@timemanx timemanx mentioned this issue Dec 20, 2024
Merged
@timemanx
Copy link
Contributor

@ronjunevaldoz, @TheDome0 I created #2066 on top of @TheDome0's PR.
It passes all the build checks and works for me too.

If possible, could you check whether it works for you.

samuelAndalon pushed a commit that referenced this issue Jan 9, 2025
@timemanx @TheDome0
Update Ktor to 3.0.3 (#2066)
835d680 
### 📝 Description
Updated Ktor and updated failing tests and fixed compile issues
resulting from the update.
Also updated some libraries. 

### 🔗 Related Issues
#2037

---------

Co-authored-by: TheDome0 <dostoeby@edu.aau.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timemanx @ronjunevaldoz @samuelAndalon